Skip to content

Conversation

piobab
Copy link
Collaborator

@piobab piobab commented Sep 12, 2023

It uses latest API from this PR mars-protocol/rover#197

It fix problem rised by @thec00n (slippage is now validated in credit-manager):

Users can trigger reward withdrawal by calling Withdraw or WithdrawLiquidity from credit manager. A malicious user can send the WithdrawLiquidity and set the minimum_receive assets to zero. 

@piobab piobab force-pushed the fix/MP-3350-slippage branch from 2aa8c97 to 91a9f74 Compare September 12, 2023 14:02
@piobab piobab requested review from dancreee and thec00n September 12, 2023 14:37
@piobab piobab merged commit f55cfb5 into release/mars-v2 Sep 13, 2023
@piobab piobab deleted the fix/MP-3350-slippage branch September 14, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants